search

qmfkdldks / vivid-editor

animated text editor
https://vivid-delta.vercel.app
0 stars 0 forks source link

added buttons for title and subtitle, added icons for bold, italic and underline #27

Closed i-fer closed 4 years ago

i-fer commented 4 years ago

… props. Style.js: added styled icons for bold, italic and underline. Changed from a to button on styles component

__ISSUE_REF__

Issue

added icons an buttons for title, subtitle, added icons for bold, icon and underline

Acceptance Criteria

user is able to see buttons on the toolbar

Screenshots

QA Steps

Give a brief list of steps to QA the changes in this PR.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/qmfkdldks/vivid/cgnlsu13o
✅ Preview: https://vivid-git-addtoolbarbuttons.qmfkdldks.vercel.app

i-fer commented 4 years ago

Can you run these commands and resolve all issues (tests and lint)? And does mark buttons work as expected?

git checkout master
git pull origin master
git checkout adding-sneak-animation
git rebase master

yarn test
yarn test:lint

where it says "git checkout adding-sneak-animation" should it be "git checkout add addToolbarButtons" ?

qmfkdldks commented 4 years ago

You are right. Can you rebase from master and fix all lint issues?

github-actions[bot] commented 4 years ago

Coverage Report

Totals Coverage
Statements: 30.59% ( 26 / 85 )
Methods: 30.77% ( 8 / 26 )