Redirect to S3 instead of proxying files.

qmk / qmk_api

QMK API, information on keyboards and keymaps, and a compile service.

http://api.qmk.fm/

Other

34 stars 21 forks source link

Redirect to S3 instead of proxying files. #32

Closed skullydazed closed 5 years ago

skullydazed commented 5 years ago

No, this one should be transparent. https://github.com/qmk/qmk_compiler/pull/35 will change what the UI sees but I don't believe that requires any changes either.

yanfali commented 5 years ago

No, this one should be transparent. qmk/qmk_compiler#35 will change what the UI sees but I don't believe that requires any changes either.

I'm more worried about the change in the status flag. is_failed looks like a boolean rather than a string

skullydazed commented 5 years ago

The code you're looking at is all client side code, consuming the same object the UI does. That object hasn't changed, I've just changed to checking a different key when waiting for results.