search

qmk / qmk_compiler

The worker process that pulls keymap jobs from the queue and compiles them
16 stars 22 forks source link

Keyboard name mismatch #41

Open i5ar opened 5 years ago

i5ar commented 5 years ago

The keymaps endpoint (e.g. https://api.qmk.fm/v1/keyboards/1upkeyboards/1up60hse/keymaps/default) shows some lack of congruence. The key keyboard_name, inside keymaps, should be probably called keyboard_folder instead. Thank you.

screenshot

...

screenshot2

This change (if it isn't too late) will also make it more consistent with the info.json:

{
  "keyboard_name": "1up60hse",
  "keyboard_folder": "1upkeyboards/1up60hse",
  "...": "..."
}
skullydazed commented 5 years ago

Thanks for bringing this to our attention. We'll look into if there's any ramifications to changing this, I don't think anyone is using it but I'm not entirely sure yet.