search

qmk / qmk_configurator

The QMK Configurator
http://config.qmk.fm
689 stars 343 forks source link

chore: clean up accumulated vue warnings #1320

Closed yanfali closed 1 month ago

yanfali commented 11 months ago

Description

yanfali commented 11 months ago

On Sat, Oct 28, 2023, 16:56 James Young @.***> wrote:

@.**** commented on this pull request.

In src/components/Keycode.vue https://github.com/qmk/qmk_configurator/pull/1320#discussion_r1375336287 :

  • width: {
  • type: String,
  • default: undefined
  • },

This was width: null previously - is that no longer valid?

Iirc we check if this is undefined before using it. Can you verify that?

—

Reply to this email directly, view it on GitHub https://github.com/qmk/qmk_configurator/pull/1320#pullrequestreview-1702863408, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARLSU45GVPG4ROAV6MAMN3YBWLUHAVCNFSM6AAAAAA6UJB3PCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBSHA3DGNBQHA . You are receiving this because you authored the thread.Message ID: @.***>