search

qmk / qmk_configurator

The QMK Configurator
http://config.qmk.fm
675 stars 340 forks source link

Key rotation #310

Open i5ar opened 5 years ago

i5ar commented 5 years ago

The QMK Firmware repository have a keyboard defining rotations (https://github.com/qmk/qmk_firmware/blob/master/keyboards/signum/3_0/elitec/info.json) but they don't seem to be correct (https://i5ar.github.io/yake/#/signum/3_0/elitec). I implemented rotations (r, rx and ry) the same way KLE does (which is the same way SVG does and probably other libraries too).
I can make a PR to fix the rotations of that keyboard but before I want to make sure the QMK Configurator will also be implementing rx and ry the same way.

This is the fix (I also moved the keys 1/4 unit to the right). You can load it here to see the changes.

yanfali commented 5 years ago

Yeah go ahead if it's not correct compared to others. We're not using rotation right now.