qmk / qmk_configurator

The QMK Configurator
http://config.qmk.fm
694 stars 348 forks source link

Add a kinesis advantage layout to converter/usb_usb/hasu #913

Open wwalker opened 3 years ago

wwalker commented 3 years ago

Description

I'd love to see a Kinesis Advantage shaped layout on the configurator for converter/usb_usb/hasu

These setups all have the advantage shaped layouts:

kinesis/alvicstep kinesis/kint2pp kinesis/stapelberg kinesis/nguyenvietyen

For the life of me I can see where the shape is tied to the keyboards. I'll do the work, just need a couple of pointers.

yanfali commented 3 years ago

check info.json

wwalker commented 3 years ago

Thank you! I didn't think about it being outside of this repo.

wwalker commented 3 years ago

How do I get my test configurator to see the changes I make in my local qmk_firmware repo?

I tried changing https://github.com/qmk/qmk_firmware to file:///home/wwalker/qmk_firmware, I assumed that was a security problem, so I changed it to a URL for a locally running webserver. Same results.

Please what am I missing? Or do I need to fork qmk_firmware and change the URL to point to my fork and push changes between tests?

yanfali commented 3 years ago

I believe the docker container is the best approach.

wwalker commented 3 years ago

The docker container is still not looking at my local qwk/qwk_firmware where I made the changes that should enable kinesis keyboard layout ( adding the layouts for kinesis to qmk_firmware/keyboards/c/converter/usb_usb/hasu/info.json )

There is absolutely nothing that I can find that tells qmk_configurator where my qmk_firmware is to get the information from said info.json

yanfali commented 3 years ago

@skullydazed probably has the magical incantation to make it all work

owbear commented 3 years ago

Did you manage to construct a LAYOUT_pretty() you'd Iike to share @wwalker ?

wwalker commented 3 years ago

@owbear yes, and no. Below is my map. I think it is good, but I cannot figure out how to test it. I can set up a test environemnt, but it is hardcoded somewhere in the javascript guts to talk to some API on the real live site. Here is the file I created:

https://github.com/wwalker/qmk_firmware/commit/537d0ddea78e7ead1408c6b59d5ce5cf036c090e

owbear commented 3 years ago

Thanks, I'll check it out when I'm back from my vacation next week.

Btw, I have layout for Kinesis on Hasu USB-USB that I'm happy with in https://github.com/owbear/qmk_firmware but I'm looking for a LAYOUT_pretty() that works