qmk / qmk_distro_msys

A Windows one-click installer for the QMK CLI
https://msys.qmk.fm/
GNU General Public License v3.0
179 stars 66 forks source link

Add Windows Terminal profile option #162

Closed fauxpark closed 1 year ago

fauxpark commented 1 year ago

Borrowed from Git for Windows: https://github.com/git-for-windows/build-extra/blob/main/installer/install.iss#L2799

zvecr commented 1 year ago

Preference is going to be that the file exists in source and installed to the location normally, rather than written out by content within the installer script.

It also shouldn't use different config than https://github.com/qmk/qmk_distro_msys/blob/main/docs/faq.md#how-do-i-configure-windows-terminal.

fauxpark commented 1 year ago

The fragment needs the install path embedded into it, so as far as I can tell it has to be done this way unless we outright disallow changing it with DisableDirPage.