search

qmk / qmk_error_page

Surfacing Errors in QMK Keyboards
https://status.qmk.fm/
MIT License
2 stars 1 forks source link

More CSS stuff #24

Closed fauxpark closed 2 years ago

fauxpark commented 2 years ago

I couldn't stop myself

yanfali commented 2 years ago

Try the following. Wrap the two text blocks in divs and watch what happens

On Thu, Feb 17, 2022, 09:45 Ryan @.***> wrote:

@.**** commented on this pull request.

In src/components/ErrorReport.vue https://github.com/yanfali/qmk_error_page/pull/24#discussion_r809312326:

@@ -161,6 +162,10 @@ export default { overflow: hidden; white-space: nowrap; border-radius: 8px;

  • display: flex;

[image: image] https://user-images.githubusercontent.com/4781841/154540130-c8baf52c-d388-4a8e-8976-40ced88c346d.png

— Reply to this email directly, view it on GitHub https://github.com/yanfali/qmk_error_page/pull/24#discussion_r809312326, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARLSUZYTQU4OEZQDCQETK3U3UX5BANCNFSM5OVEST2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

fauxpark commented 2 years ago

I see it.

display: grid; seems to fix it.

yanfali commented 2 years ago

Works for me.

On Thu, Feb 17, 2022, 10:04 Ryan @.***> wrote:

I see it.

display: grid; seems to fix it.

— Reply to this email directly, view it on GitHub https://github.com/yanfali/qmk_error_page/pull/24#issuecomment-1043252103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARLSU34FB5AEQUBIFGKDOLU3U2BPANCNFSM5OVEST2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

yanfali commented 2 years ago

You could also try flex-direction: column

On Thu, Feb 17, 2022, 10:04 Ryan @.***> wrote:

I see it.

display: grid; seems to fix it.

— Reply to this email directly, view it on GitHub https://github.com/yanfali/qmk_error_page/pull/24#issuecomment-1043252103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARLSU34FB5AEQUBIFGKDOLU3U2BPANCNFSM5OVEST2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

fauxpark commented 2 years ago

Nope, no vertical centering with that.