search

qmk / qmk_error_page

Surfacing Errors in QMK Keyboards
https://status.qmk.fm/
MIT License
2 stars 1 forks source link

Break down ErrorReport component #34

Closed fauxpark closed 1 year ago

fauxpark commented 1 year ago

Probably overengineering this but I've found it to be a nice little playground to familiarise myself with Vue.

fauxpark commented 1 year ago

Filtering seems slightly more sluggish (eg. searching for gh60 then backspacing to empty, particularly the last char). But there was already a bit of delay there, so I don't know if there's much room for improvement.

yanfali commented 1 year ago

Filtering seems slightly more sluggish (eg. searching for gh60 then backspacing to empty, particularly the last char). But there was already a bit of delay there, so I don't know if there's much room for improvement.

the way you're doing filtering did look a bit concerning to me, but I haven't looked into it

yanfali commented 1 year ago

Ah, so one reason for a perception of slow down is likely because of all the extra overhead of components. Those are being created and removed in quick succession and create more memory pressure on the VM. In the existing janky implementation it's a single component manipulating the DOM. So it's less clean, but it's very performant as it's only simple DOM manipulation.

fauxpark commented 1 year ago

the way you're doing filtering did look a bit concerning to me, but I haven't looked into it

I got it from here, first result in google for "vue filter search": https://codepen.io/AndrewThian/pen/QdeOVa

yanfali commented 1 year ago

the way you're doing filtering did look a bit concerning to me, but I haven't looked into it

I got it from here, first result in google for "vue filter search": https://codepen.io/AndrewThian/pen/QdeOVa

Well you know what they say. Some algorithms scale when n is small.

fauxpark commented 1 year ago

@yanfali This is ready to go, I guess, unless you have some ideas on how to do filtering better. vue-virtual-scroller perhaps? https://github.com/Akryum/vue-virtual-scroller

yanfali commented 1 year ago

I thought this was slower than the previous version? I'll take a look today.

fauxpark commented 1 year ago

Not egregiously slower. It's still very usable.

yanfali commented 1 year ago

sorry I messed with history a bit on master to clean up deploy. This may mess with your timeline.

fauxpark commented 1 year ago

Seems to have obliterated these changes :(

yanfali commented 1 year ago

Nothing is every really lost on git so we should be able to get them back.