qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.22k stars 39.23k forks source link

Travis CI build fails when keyboard name contains numbers #1075

Closed dungdung closed 7 years ago

dungdung commented 7 years ago

Came across this after submitting #1074 which only contains changes for the KC60

This seems to be due to travis_build.sh grepping for [a-zA-Z_]+ instead of [0-9a-zA-Z_]+.

MKB=$(git diff --name-only -n 1 ${TRAVIS_COMMIT_RANGE} | grep -oP '(?<=keyboards\/)([a-zA-Z_]+)' | sort -u)

Will submit a fix for this.

jackhumbert commented 7 years ago

Just fixed - thanks :)