qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.02k stars 38.73k forks source link

[Bug] Looks like 0.11.0 broke something for jj40 #11389

Open Artheg opened 3 years ago

Artheg commented 3 years ago

Hi,

I've wanted to alter the keymap for my jj40 board. When I flashed the firmware, keys started to behave strange. Sometimes there was no output at all, sometimes they would 'stick' (e.g. I type 'g' and the output goes 'gggggg...' until I hit 'g' again) and sometimes there would be a delay after I hit the key. Backlight Underglow wouldn't work at all. I've tried to compile the firmware both locally and on the website and I've had the same effect.

With the help of guys in discord (spidey3, Dasky) it was figured out that the last firmware that was working was compiled with 0.10.54. Everything after that just didn't work.

ollien commented 2 years ago

@zvecr Gotcha, thanks. I was mostly inferring based on the comments above. This solution does seem to work, but obviously it's not optimal.

eddible commented 2 years ago

Just to add to the above, I had this exact issue with a FaceW PCB, and adding #define IGNORE_ATOMIC_BLOCK to config.h fixed it.

val-m4 commented 2 years ago

@eddible this fix didn't help me.

I have found out, that the keyboard (sesame) does not work with a laptop (dell XPS) with USB 3. But when I plug in the USB hub 2.0, it starts working and processing keypresses, shutter still present. I've put some debug code into the firmware. This is how it looks for me

tzarc commented 2 years ago

@eddible this fix didn't help me.

I have found out, that the keyboard (sesame) does not work with a laptop (dell XPS) with USB 3. But when I plug in the USB hub 2.0, it starts working and processing keypresses, shutter still present. I've put some debug code into the firmware. This is how it looks for me

Matrix debug output is likely the culprit, here. Does it stutter with the printouts disabled?

val-m4 commented 2 years ago

@eddible this fix didn't help me. I have found out, that the keyboard (sesame) does not work with a laptop (dell XPS) with USB 3. But when I plug in the USB hub 2.0, it starts working and processing keypresses, shutter still present. I've put some debug code into the firmware. This is how it looks for me

Matrix debug output is likely the culprit, here. Does it stutter with the printouts disabled?

Yes. The same. If pressing really fast the key keyboard outputs with a small delay, then freeze for a second or so, and then outputs without pressing that key. This behavior is the same with debug mode and works just with a USB 2.0 hub.

tzarc commented 2 years ago

I'm not sure, then. I can't reproduce this behaviour on my jj40, running the default keymap, with no core modifications.

val-m4 commented 2 years ago

I'm not sure, then. I can't reproduce this behaviour on my jj40, running the default keymap, with no core modifications.

It seems to me, that the problem also is in the USB. I've used the old version 0.10.47 and it works almost ok, with USB 2.0 hub, and doesn't work in case of a direct connection to USB 3.0, without a hub. Also, it has more issues with connection when the laptop is powered by a battery.

tzarc commented 2 years ago

and doesn't work in case of a direct connection to USB 3.0, without a hub

That's the scenario I was testing here, and it works fine...