Momentarily set default layer

[joshdotblack]

Hi there,

Looking through some of the planck keymaps, I noticed rather than turning layers on or off, you're setting the default layer. I think this is a great idea, and it makes way more sense to people new to mechanical keyboards to say you're switching to a layer vs teaching them about the layer stack.

I was wondering if you've had any ideas on implementing a momentary alternative to the switching you're doing right now - so switch the default layer while the key is held, then switch it back to the previous default layer when the key is released.

I've been hacking around with it for a little while but I've not made much progress, your thoughts on a solution would be great to hear if you have them - happy to implement and submit a pull request if you can point me in the right direction :)

[eyJhb]

Isn't that what LT is used for? Eg. when holding the key, it switches to layer two, if only tapping it sends the key. LT(2, DA_AE) // danish æ

To toggle between layers, TG(2) would be used :)

[joshdotblack]

@eyJhb: It is indeed, but only for toggling layers, I'm looking to set the default layer instead so the user can move both up and down the layer stack. Also, TG/LT wouldn't allow the user to attach custom actions to layer switching (like changing the backlight brightness for example) :)

[Avispa]

Not sure, but I think I have a similar problem. So far I used DF(...) to switch to the desired layer (to change the keyboard layout). Related to my current investigation that screws visiualizer.c because it never notice a change. TG or LG is not what I am looking for -- I don't wanna have a second key on top nor a toggle.

Side note, even though I have the idea I read it already somewhere, with TG(...) only the LCD on the keyboard half where the TG(...) key is displays the layer change. (ErgoDox Infintiy)

[fredizzimo]

@Avispa, changing the default layer is supposed to work correctly with the visualizer.

So there's either a bug in the visualizer or the your implementation. I can investigate that, if you have a link to your keymap.

[Avispa]

@fredizzimo: sure here it is: wasp/keymap.c.

Since I updated also the other half -- just doing this irregular -- the problem that only the "current" half updates it's LCD is solved. However DF(..) still doesn't effect state->status.layer or visualizer doesn't pick up on it at least. In general: how is this state->status.layer supposed to work?? As you can see in my keymap.c, QWERTZ is/should the first layer while KAY is the second. Nevertheless also with TG(..) KAY picks up on 0x3 what appears somehow confusing to me. ;)

Bye the way, should't MO(..) effect visualizer.c too? For me it doesn't as well.

[drashna]

There may need bo something called in default_layer_state_set_user.

[jackhumbert]

I think this could be accomplished with process_record_user and a custom keycode that sets the default layer on press/release. I think we can close this for now, but if anyone has code to share that implements something similar, that would be great.