qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.28k stars 39.38k forks source link

[Feature Request] Support switches with integrated diodes for ergodox_ez #12176

Closed anbroid closed 3 years ago

anbroid commented 3 years ago

Feature Request Type

Description

If you use Cherry MX switches with builtin diodes on an ergodox_ez (part number of the switches will end in DW such as MX1A-G1DW or MX3A-L1DW) the diode direction in both sides of the keyboard will be same (not symmetrical) and the left side does not work with the qmk firmware. In the original (Ben Blazak) ergodox firmware you could make this change to options.h

-       #define  MCP23018__DRIVE_ROWS     0
-       #define  MCP23018__DRIVE_COLUMNS  1
+       #define  MCP23018__DRIVE_ROWS     1
+       #define  MCP23018__DRIVE_COLUMNS  0

which allows such keyboards to work. Could you add a similar flag to to support such switches? I have an original ergodox keyboard with such switches and can compile and test patches if it helps.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs. For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

stale[bot] commented 3 years ago

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.

anbroid commented 3 years ago

issue is still valid, can someone please reopen it?