qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.28k stars 39.38k forks source link

[Bug] Moonlander Keyboard: Incorrect RGB-matrix neighbors for thumb-cluster. #14966

Closed NorthGuard closed 3 years ago

NorthGuard commented 3 years ago

Describe the Bug

Some reactive RGB matrix lighting use the LED specifications to determine which keys are neighbors (I think it is in g_is31_leds), like the reactive heatmap. I use the Moonlander from Ergodox-ez and noticed that the neighboring keys do not really make sense for the thumb-cluster.

Specifics

Here's a video shoving a couple of examples: https://drive.google.com/file/d/1ZSg2fuWe9Fy7GwoCCkaerQJbuuqffoBP

System Information

filterpaper commented 3 years ago

Duplicate of #14041. See the explanation in that issue.

NorthGuard commented 3 years ago

Duplicate of #14041. See the explanation in that issue.

Ah yes, thanks! I'll close this one :)