qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.35k stars 39.52k forks source link

[Bug] AUDIO_CLICKY tuneables cause random lockups on Preonic #16105

Closed era1112 closed 2 years ago

era1112 commented 2 years ago

Describe the Bug

Code details (all in config.h):

Enabling clicky mode on it's own (ie, with default parameters) is stable.

#define AUDIO_CLICKY            

Problem presents when making reasonable adjustments to the parameters that the guide says are tuneable. This is one example of settings that cause the lockups:

// Clicky mode parameter deviations
#define AUDIO_CLICKY_FREQ_MIN       65.0f       // Default 65
#define AUDIO_CLICKY_FREQ_DEFAULT   800.0f      // Default 440
#define AUDIO_CLICKY_FREQ_MAX       1500.0f     // Default 1500
#define AUDIO_CLICKY_FREQ_FACTOR    1.18921f    // Default 1.18921
#define AUDIO_CLICKY_FREQ_RANDOMNESS    1.0f        // Default 0.05, guide suggests 1.0 for an interesting effect
#define AUDIO_CLICKY_DELAY_DURATION     1           // Default 1

You can inspect my code on my dev_branch. There are a lot of other features enabled in that keymap, but the problem is the same if I start with the default firmware and only add clicky mode.

Possible steps to remediate

System Information

drashna commented 2 years ago

Is a known issue: https://github.com/qmk/qmk_firmware/issues/12080

Try setting the driver to dac_additive, as that seems to work bet for me.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs. For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

github-actions[bot] commented 2 years ago

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know. // [stale-action-closed]