qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.97k stars 38.62k forks source link

sick68 currently uses 0xFEED as VENDOR_ID #16509

Closed xia0 closed 2 years ago

xia0 commented 2 years ago

cc @umbynos

In reference to sick68 keyboard https://github.com/qmk/qmk_firmware/tree/master/keyboards/handwired/sick68 Specifically https://github.com/qmk/qmk_firmware/blob/master/keyboards/handwired/sick68/config.h VENDOR_ID is currently set to the default value 0xFEED. Can this please be changed so that a via port can be written?

umbynos commented 2 years ago

Yeah this can be done, should I generate a random/unique one?

xia0 commented 2 years ago

Yeah this can be done, should I generate a random/unique one?

I think the recommendation is pick one that might be meaningful to you. From what I have read, the vendor id seems informal and only VIA cares about it not being the default probably because they use the vendor id and product id to identify the device.

umbynos commented 2 years ago

0x5E68 could be a good fit?

xia0 commented 2 years ago

0x5E68 could be a good fit?

Sure

xia0 commented 2 years ago

via keymap PR has been merged (https://github.com/qmk/qmk_firmware/pull/16508) Just waiting on vendor id change before it can be submitted to the via repository. Would you like for me to submit a PR with the vendor id as 0x5E68?

umbynos commented 2 years ago

Done!

xia0 commented 2 years ago

Thanks!