[Feature Request] Reorganize the Sofle family folders

[brianlow]

Reorganize the sofle code so keymaps are specific to hardware variation, all organized under a top level sofle folder

Feature Request Type

• [ ] Core functionality
• [ ] Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
• [x] Alteration (enhancement/optimization) of existing feature(s)
• [ ] New behavior

Description

Proposed folder structure:

keyboards/sofle/              # no code in this folder, just for grouping the family

    original/                 # moved from sofle/rev1                 
      keymaps/                      
        default/     
        flare56/              # no RGB code, so assume for the Sofle v1/v2
        helltm                # no RGB code, so assume for the Sofle v1/v2
        j4ckofalltrade        # no RGB code, so assume for the Sofle v1/v2
        killmaster            # no RGB code, so assume for the Sofle v1/v2
        manna-harbour_miryoku # no RGB code, so assume for the Sofle v1/v2

    rgb/                      # copy of sofle/rev1
      keymaps/
        default/              # renamed from rgb_default
        devdev/               # has RGB code, so assume for the Sofle RGB

    keyhive                   
      keymaps/
        default/              # copy of the current default keymap
        via/                  # renamed from keyhive_via

    choc                      # moved from from keyboards/sofle_choc
      keymaps
        default/
        via/   

Background

• When adding Sofle Choc support it was noticed that keymaps are organized under what I believe is an old folder structure (see PR comment). The recommended structure is /keymaps/family/hardware-variant/keymaps

Pros

• keymaps are specific to the hardware variant
• hardware variants no longer share code so changes are isolated
• better CI since default/via keymaps will be built against hardware-variant specific code
• organized under a single family folder for easier discovery

Happy to make this change but want approval from hardware maintainers. If I don't heard back after a month I'll assume you are no longer maintaining and are ok with the change.

• Sofle v1/v2: @josefadamcik
• Sofle RGB: @DaneEvans
• Sofle Keyhive: @winder

[winder]

This proposal looks good to me.

[josefadamcik]

Looks great to me, thanks for doing this!

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs. For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

[duese]

This issue is not stale. I created a PR (#17979) 5 days ago according to the proposal of @brianlow. I'm not sure how the process is now, who needs to review/approve that PR?

[waffle87]

a collaborator who has some free time to review it. tldr; just need to be patient now.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs. For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

[github-actions[bot]]

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know. // [stale-action-closed]

[ireun]

Any progress with that?

[duese]

Any progress with that?

I'm waiting for PR #16736 being accepted and merged. Than we can continue on restructuring the sofle family.