Open rubienr opened 1 year ago
With UCIS_ENABLE = yes in rules.mk when defining a symbol whose name contains a number ([0-9]), the symbol name is never matched.
UCIS_ENABLE = yes
rules.mk
[0-9]
Example:
const ucis_symbol_t ucis_symbol_table[] = UCIS_TABLE( UCIS_SYM("poop", 0x1F4A9), // 💩 UCIS_SYM("grin", 0x1F600), // 😀 UCIS_SYM("grin2", 0x1F601), // 😁 ); void ucis_symbol_fallback(void) { send_unicode_string("💩"); }
Suggestion: Fix the line in process_ucis.c:41 in function is_uni_seq(char *seq) since the ASCII code '0' comes before '9' (asciitable.com):
is_uni_seq(char *seq)
Fix:
if ('0' <= seq[i] && seq[i] <= '9') {
Keychron Q6
-
Linux
No response
Can somebody confirm this is the correct way to fix the issue? I'd then prepare a PR.
Probably related to https://github.com/qmk/qmk_firmware/pull/21659
Describe the Bug
With
UCIS_ENABLE = yes
inrules.mk
when defining a symbol whose name contains a number ([0-9]
), the symbol name is never matched.Example:
Suggestion: Fix the line in process_ucis.c:41 in function
is_uni_seq(char *seq)
since the ASCII code '0' comes before '9' (asciitable.com):Fix:
Keyboard Used
Keychron Q6
Link to product page (if applicable)
-
Operating System
Linux
qmk doctor Output
No response
Is AutoHotKey / Karabiner installed
Other keyboard-related software installed
-
Additional Context
No response