qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.39k stars 39.6k forks source link

[Bug] Modifier should be sent before regular key #23349

Open ibash opened 8 months ago

ibash commented 8 months ago

Describe the Bug

Steps:

  1. Turn on console + matrix debugging
  2. Press "cmd" + "a" simultaneously

Expected:

  1. "cmd" gets reported first and then "a" gets reported (so that the OS recognizes "cmd+a" as select all)

Actual:

  1. "cmd" and "a" gets reported at the same time, so macOS doesn't recognize it

Keyboard Used

keychron/q3/ansi

Link to product page (if applicable)

No response

Operating System

14.4 (23E214)

qmk doctor Output

~/Projects/qmk_firmware keychron-hc595* ⇡
❯  qmk doctor
Ψ QMK Doctor is checking your environment.
Ψ CLI version: 1.1.5
Ψ QMK home: /Users/islam/Projects/qmk_firmware
Ψ Detected macOS 14.4 (Apple Silicon).
Ψ Git branch: keychron-hc595
Ψ Repo version: 0.19.4
⚠ Git has unstashed/uncommitted changes.
Ψ - Latest keychron-hc595: 2024-03-18 13:17:41 -0700 (6bed9f600c0) -- Per key debouncing at 5ms
Ψ - Latest upstream/master: 2023-06-24 11:54:23 -0700 (3a42fbb0c9f) -- Mechlovin Zed65 rev1 Touch-Up (#21373)
Ψ - Latest upstream/develop: 2023-06-26 11:36:32 +0300 (3ebdb1258bc) -- Chibios USB: Take into account if host wants remote wakeup or not (#21287)
Ψ - Common ancestor with upstream/master: 2022-12-15 05:19:39 -0300 (33cc81f36ef) -- [Keymap] Simplifying ortho-4x12 jotix's layout (#19336)
Ψ - Common ancestor with upstream/develop: 2022-12-15 05:19:39 -0300 (33cc81f36ef) -- [Keymap] Simplifying ortho-4x12 jotix's layout (#19336)
Ψ CLI installed in virtualenv.
Ψ All dependencies are installed.
Ψ Found arm-none-eabi-gcc version 13.2.1
Ψ Found avr-gcc version 8.5.0
Ψ Found avrdude version 7.3
Ψ Found dfu-util version 0.11
Ψ Found dfu-programmer version 1.1.0
Ψ Submodules are up to date.
Ψ Submodule status:
Ψ - lib/chibios: 2022-09-18 10:01:17 +0000 --  (0e9d558b5)
Ψ - lib/chibios-contrib: 2022-10-03 18:09:41 +0200 --  (bb8356fb)
Ψ - lib/googletest: 2021-06-11 06:37:43 -0700 --  (e2239ee6)
Ψ - lib/lufa: 2022-08-26 12:09:55 +1000 --  (549b97320)
Ψ - lib/pico-sdk: 2022-09-19 18:02:44 +0200 --  (8d56ea3)
Ψ - lib/printf: 2022-06-29 23:59:58 +0300 --  (c2e3b4e)
Ψ - lib/vusb: 2022-06-13 09:18:17 +1000 --  (819dbc1)
Ψ QMK is ready to go, but minor problems were found

Is AutoHotKey / Karabiner installed

Other keyboard-related software installed

No response

Additional Context

I am using keychron's branch, this exact commit: https://github.com/ibash/qmk_firmware/tree/keychron-hc595

ibash commented 8 months ago

Here's a screenshot of the keymap log, cmd + a is sent in the same report but not detected as a "select-all" from the macOS side

Screenshot 2024-03-25 at 11 39 30 AM