qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.47k stars 37.7k forks source link

Skip parsing g_led_config when matrix_size is missing #23941

Closed zvecr closed 4 days ago

zvecr commented 2 weeks ago

Description

From the recent core CI runs, qmk find -km all currently falls over due to recent changes, where matrix_size is no longer present in .json.

Also added qmk --verbose find handling so that diagnosing issues is somewhat easier.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fauxpark commented 2 weeks ago

This should never need to be skipped because matrix_size should always be present internally, either derived from the row/col/direct pins arrays, or parsed from config.h for custom matrix. This issue is a symptom of a failure earlier on which happens to cause matrix_size not to be assigned.

fauxpark commented 2 weeks ago

It appears all of the boards causing this error are the ones which are completely failing schema validation, ie. these ones:

Ψ Retrieving list of all keyboards and keymaps...
Oh no darkproject/kd87a_bfg_edition
Oh no doio/kb38
Oh no handwired/alcor_dactyl
Oh no kbdfans/kbdpad/mk3
Oh no meletrix/zoom98
Oh no projectd/65/projectd_65_ansi
Oh no projectd/75/ansi
Oh no projectd/75/iso
Oh no rot13labs/h4ckb0ard
Oh no skeletonkbd/frost68
Oh no theone

The same command run on that branch succeeds. Not sure why the EC980C and BAMFK4 do not show up here though.