qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.47k stars 37.7k forks source link

Adding Ploopyco functions so Host State Control can be implemented for Ploopy Nano #23953

Open t4corun opened 2 weeks ago

t4corun commented 2 weeks ago

Addressed gap in Ploopy Nano where drag scroll and dpi cannot be accessed at the userspace level. User can now implement Host State Control in their keymap

Description

Extends on the current code base. Drag scroll variable and dpi cycling logic moved into functions so they can be called at the userspace level.

Types of Changes

Issues Fixed or Closed by This PR

N/A

Checklist

t4corun commented 2 weeks ago

Revised PR based on @obosob's Discord comment. Removed keyboard level Host State control. Leave it to the user to implement it at the keymap. Tested on my Ploopy Nano.

The previous commit still has the Host state control if that is still desired.

drashna commented 2 weeks ago

Revised PR based on obosob's Discord comment. Removed keyboard level Host State control. Leave it to the user to implement it at the keymap. Tested on my Ploopy Nano.

Agree with obosob. This is something best left implemented at the user level.

However the helper functions are a good idea and useful.

t4corun commented 2 weeks ago

Thanks, but credit to @obosob for the idea. I was originally trying to call the ploopyco DRAG_SCROLL from my other QMK boards and was struggling