qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.47k stars 37.7k forks source link

[CLI] Force `dump_lines()` to always use Unix line endings #23954

Closed fauxpark closed 2 weeks ago

fauxpark commented 2 weeks ago

Description

When running ./util/regen.sh on Windows, every file generated (using dump_lines()) gets its newlines changed from LF to CRLF regardless of if there are any substantial changes to them. Since we enforce LF through Git anyway, this shouldn't really affect anything but we can turn off this noise by telling write_text() to use LF all the time.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fauxpark commented 2 weeks ago

TypeError: write_text() got an unexpected keyword argument 'newline'

Hm, seems to have been added in Python 3.10...