Fix docker_cmd.sh when userspace is not configured - Githubissues

qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

17.46k stars 37.68k forks source link

Fix docker_cmd.sh when userspace is not configured #23997

Closed zvecr closed 6 days ago

zvecr commented 6 days ago

Description

Running with userspace not configured produces the following error:

./util/docker_cmd.sh: 55: cd: can't cd to None

The issue being that the None returned from QMK_USERSPACE printing out where the preceding checks expect empty string.

Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation

Issues Fixed or Closed by This PR

https://discord.com/channels/440868230475677696/473506116718952450/1255333192655962122

Checklist

[x] My code follows the code style of this project: C, Python
[x] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).