qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.46k stars 37.68k forks source link

Update Lisa #24005

Closed key10iq closed 2 days ago

key10iq commented 3 days ago

Description

My update adds the ability to configure the indicator LEDs function directly from VIA

Types of Changes

Issues Fixed or Closed by This PR

Checklist

waffle87 commented 3 days ago

Unfortunately this cannot be accepted, as custom VIA indicator code is not currently not accepted to the qmk_firmware repository due to the maintenance burden it poses.

key10iq commented 3 days ago

Unfortunately this cannot be accepted, as custom VIA indicator code is not currently not accepted to the qmk_firmware repository due to the maintenance burden it poses.

Is this considered a custom VIA code? https://github.com/key10iq/keyboards/blob/Lisa/v3/keyten/lisa/lisa.json

This is controlled like a regular multilayout

zvecr commented 3 days ago

From the PR checklist:

keyboard updates and refactors (eg. to data driven) must go through develop to reduce master -> develop merge conflicts

And with https://docs.qmk.fm/ChangeLog/20240526#migration-of-via-keymaps-to-via-team-control, we would certainly not be accepting any further keyboard level via customisation.

key10iq commented 2 days ago

Got it, thanks