qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.46k stars 37.68k forks source link

`horrortroll/handwired_k552`: fix RGB Matrix LED config #24014

Closed fauxpark closed 2 days ago

fauxpark commented 2 days ago

Description

Moving g_led_config for this board to data driven. Since all of the LEDs appear to be marked as underglow this mismatch is not much of an issue:

⚠ horrortroll/handwired_k552: led_config: handwired_k552.c: Number of columns in row 0 (16) does not match matrix (17)

CC @HorrorTroll, would appreciate some verification if possible.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fauxpark commented 2 days ago

image This looks like it might be out of order?

HorrorTroll commented 2 days ago

This looks like it might be out of order?

Ahh, probably I was typo wrong order for it. Can you resolved that one for me? Thanks.

fauxpark commented 2 days ago

Done. Everything else look good?

HorrorTroll commented 2 days ago

Yes, everything look good now.