issues
search
qmk
/
qmk_firmware
Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.46k
stars
37.68k
forks
source link
Remove custom keycodes from nullbitsco/snap
#24017
Closed
zvecr
closed
2 days ago
zvecr
commented
2 days ago
Description
Not used by any in tree keymap
Not implemented correctly
VIA custom keycode require kb block
KB level keycodes should not be using the user block
Implement shutdown logic without re-implementing
QK_BOOT
Types of Changes
[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[x] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation
Issues Fixed or Closed by This PR
Checklist
[x] My code follows the code style of this project:
C
,
Python
[x] I have read the
PR Checklist
document
and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the
CONTRIBUTING
document
.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
Description
QK_BOOT
Types of Changes
Issues Fixed or Closed by This PR
Checklist