qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.46k stars 37.68k forks source link

`dp60`: move RGB Matrix LED config to data driven #24022

Open fauxpark opened 2 days ago

fauxpark commented 2 days ago

Description

⚠ dp60: led_config: dp60.c: Number of columns in row 0 (14) does not match matrix (15)

This is a weird one. The number of columns in the LED config is actually correct; instead the MATRIX_COLS define is the issue. However, rendered out it still doesn't quite make sense to me. image image

For reference, an image of the board's per-key LEDs. All 72 LEDs are accounted for, but their matrix positions and ordering is all over the place. This goes all the way back to the original source: https://github.com/yulei/qmk_firmware/blob/wm690/keyboards/stm60/dp60/dp60.c

I think the ISSI config may be partially to blame here, as it does not have to be in a particular order, but it necessarily forces the RGB Matrix config to follow that order.

CC @yulei, would you be able to provide either a fixed version of this config, or the board schematics (at least the relevant parts) so that I can do it?

Types of Changes

Issues Fixed or Closed by This PR

Checklist