qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.48k stars 37.73k forks source link

Addition of EC 60X #24028

Closed Cipulot closed 2 days ago

Cipulot commented 5 days ago

Description

Addition of the EC 60X.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

dunk2k commented 5 days ago

@Cipulot Could you confirm the matrix co-ordinates (i.e. 3,5) for split Right Shift that is 1.75u-1u?

Cipulot commented 5 days ago

@Cipulot Could you confirm the matrix co-ordinates (i.e. 3,5) for split Right Shift that is 1.75u-1u?

keyboard-layout

Cipulot commented 5 days ago

The community layouts have been added, further support is not necessary tbh. the other 23235345345 bazillion of options are just for the 1/2 ppl that want to use them, and they will use them through VIA anyway.

Cipulot commented 5 days ago

the sequence isn't to be modified to comply with how the matrix scan is performed, since they are used for the scan at a PCB electrical level, the changes will be disregarded. If that breaks the addition of the community layout support applied prior, then I'll remove that too, the support of community layout isn't a thing we look for in this particular case

Cipulot commented 5 days ago

Actually, now that I think of it I won't add them at all, sorry man

dunk2k commented 5 days ago

Actually, now that I think of it I won't add them at all, sorry man

Thanks for saying 😊

For the benefit of users, Could respective KLE image be added into readme.md?