Closed JellyTitan closed 2 days ago
The sofle_choc has the same VendorID and ProductID as sofle/rev1. This PR changes the VID/PID for sofle_choc to make them unique. The keyboard creator, Brian Low, approved the VID/PID update. I checked for conflicts between the new VID/PID in the latest QMK and didn't find any.
I went with "BL" (Brian Low) for vendor ID & "SC" (Sofle Choc) for ProductID.
@brianlow tagging for visibility.
This was initially submitted as https://github.com/qmk/qmk_firmware/pull/23080 - but i accidentally closed that one when trying to update from master.
This has merge issues.
I'm embarrassed - i forgot to update from master before submitting the PR. I brought it up to date, and it's ready for review.
The sofle_choc has the same VendorID and ProductID as sofle/rev1. This PR changes the VID/PID for sofle_choc to make them unique. The keyboard creator, Brian Low, approved the VID/PID update. I checked for conflicts between the new VID/PID in the latest QMK and didn't find any.
I went with "BL" (Brian Low) for vendor ID & "SC" (Sofle Choc) for ProductID.
@brianlow tagging for visibility.
This was initially submitted as https://github.com/qmk/qmk_firmware/pull/23080 - but i accidentally closed that one when trying to update from master.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist