Add gmkb keyboard - Githubissues

qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

17.48k stars 37.73k forks source link

Add gmkb keyboard #24039

Closed diana202402 closed 2 days ago

diana202402 commented 3 days ago

Description

Add gmkb keyboard

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[x] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[x] My code follows the code style of this project: C, Python
[x] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

diana202402 commented 3 days ago

You seem to be attempting to add this as a personal project, rather than alongside the existing keyboards/doio/ keyboards?

@zvecr Hi, I can't revert the files I previously modified, So I used a new personal account to update the code.

zvecr commented 3 days ago

Hi, I can't revert the files I previously modified, So I used a new personal account to update the code.

That doesn't make any sense.

It would need to be keyboards/doio/nindoio (or something similar). Anything associated to your accounts username is invalid.

diana202402 commented 2 days ago

Hi, I can't revert the files I previously modified, So I used a new personal account to update the code.

That doesn't make any sense.

It would need to be keyboards/doio/nindoio (or something similar). Anything associated to your accounts username is invalid.

@zvecr Hi ,if I

Hi, I can't revert the files I previously modified, So I used a new personal account to update the code.

That doesn't make any sense.

It would need to be keyboards/doio/nindoio (or something similar). Anything associated to your accounts username is invalid.

@zvecr HI， I have reverted the pull request as DOIO account.I clesed this pull request. Thank you for your help.