`salicylic_acid3/setta21`: fix RGB Matrix LED config - Githubissues

qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

17.48k stars 37.73k forks source link

`salicylic_acid3/setta21`: fix RGB Matrix LED config #24041

Closed fauxpark closed 1 day ago

fauxpark commented 3 days ago

Description

⚠ salicylic_acid3/setta21/rev1: led_config: rev1.c: Number of columns in row 1 (5) does not match matrix (6)

Moved the LED config to keyboard.json and fixed it up based on the Kicad PCB files: https://github.com/Salicylic-acid3/PCB_Data/tree/master/Setta21/v1/Kicad/Assemble

Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[x] Enhancement/optimization
[x] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[x] My code follows the code style of this project: C, Python
[x] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).