qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.08k stars 38.87k forks source link

fix: corne oled modifiers #24260

Closed Diaoul closed 1 month ago

Diaoul commented 1 month ago

There is a bug causing a visual glitch when multiple modifiers are pressed at the same time

Description

Fix it

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Does not apply

waffle87 commented 1 month ago

Looks like the rest of the splitkb/aurora keyboards also have this issue. If you're comfortable adding this fix to those, that would be welcome.

aurora/corne/corne.c:    if (modifiers & MOD_MASK_GUI & MOD_MASK_ALT) {
aurora/lily58/lily58.c:    if (modifiers & MOD_MASK_GUI & MOD_MASK_ALT) {
aurora/sofle_v2/sofle_v2.c:    if (modifiers & MOD_MASK_GUI & MOD_MASK_ALT) {
aurora/helix/helix.c:    if (modifiers & MOD_MASK_GUI & MOD_MASK_ALT) {
aurora/sweep/sweep.c:    if (modifiers & MOD_MASK_GUI & MOD_MASK_ALT) {

aurora/helix/helix.c:    if (modifiers & MOD_MASK_CTRL & MOD_MASK_SHIFT) {
aurora/corne/corne.c:    if (modifiers & MOD_MASK_CTRL & MOD_MASK_SHIFT) {
aurora/sweep/sweep.c:    if (modifiers & MOD_MASK_CTRL & MOD_MASK_SHIFT) {
aurora/sofle_v2/sofle_v2.c:    if (modifiers & MOD_MASK_CTRL & MOD_MASK_SHIFT) {
aurora/lily58/lily58.c:    if (modifiers & MOD_MASK_CTRL & MOD_MASK_SHIFT) {
Diaoul commented 1 month ago

Sure thing!