Tweak OS detection, add set_single_default_layer - Githubissues

qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

18.08k stars 38.87k forks source link

Tweak OS detection, add set_single_default_layer #24295

Closed andrebrait closed 1 month ago

andrebrait commented 1 month ago

Description

OS_DETECTION_DEBOUNCE bumped from 200 to 250
Add OS_DETECTION_MULTI_REPORT to control multiple reports
Default is now a single report, unless multiple is enabled
Prevents cases of instability when USB events are a bit funky
Works for every device I could test, including ARM MacBooks
Add set_single_default_layer to match set_single_persistent_default_layer

Types of Changes

[X] Core
[ ] Bugfix
[ ] New feature
[X] Enhancement/optimization
[ ] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[X] Documentation

Issues Fixed or Closed by This PR

None

Checklist

[X] My code follows the code style of this project: C, Python
[X] I have read the PR Checklist document and have made the appropriate changes.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna commented 1 month ago

This is two different changes, and needs to be separated out into separate PRs.

andrebrait commented 1 month ago

This is two different changes, and needs to be separated out into separate PRs.

Will do that. I'll modify this one to only contain the changes to OS detection and submit another one with the changes for set_single_default_layer