qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.09k stars 38.89k forks source link

Ergodox EZ: lights flash repeatedly when connected to shut-down Windows computer #358

Closed adiabatic closed 8 years ago

adiabatic commented 8 years ago

All this testing was done with three machines:

I've noticed that my Ergodox EZ will flash its three lights in quick succession (first red, then green, then blue in a sort of wave) at weird times. This multicolored flash, which I'll call "rainbowing", happens repeatedly, while the computer is off, if I shut my computer off directly from Windows 10.

Ordinarily this would be harmlessly cute, but I sleep in the same room as the keyboard and I don't want to have to either reboot into OS X just to make the blinkenlights stop shining.

Here's what I've noticed after a bit of experimentation:


Is there anything else I can do to have my keyboard not flash lights at me when I shut down straight from Windows in the evening?

jackhumbert commented 8 years ago

Do you have your firmware on github? There are some Makefile options to mess around with, namely SLEEP_LED_ENABLE. This really sounds more like the keyboard power cycling, though. If you look in ergodox_ez.c, you can remove ergodox_blink_all_leds(); from matrix_init_kb, and this should stop.

adiabatic commented 8 years ago

Do you have your firmware on github?

Yup!

If I stick SLEEP_LED_ENABLE = no in …/ergodox_ez/keymaps/zweihander-osx/makefile.mk, will it get picked up automatically by the typical make clean && make KEYMAP=zweihander-osx invocation?

jackhumbert commented 8 years ago

Yeap! :)

ezuk commented 8 years ago

@adiabatic did it do the trick?

ezuk commented 8 years ago

And thanks @jackhumbert!

adiabatic commented 8 years ago

Yup, that did it. Thanks, @jackhumbert!