search

qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.25k stars 39.33k forks source link

HHKB NKRO not enabled on startup #3755

Closed chadgrossman closed 6 years ago

chadgrossman commented 6 years ago

Hello,

I have 2 HHKB's with Hasu's controller (one BT one standard) and both seem to not like having NKRO enabled on plugin/startup (this is over USB on both, not BT). I've added "#define FORCE_NKRO" in config.h and "NKRO_ENABLE = yes" in rules.mk but both don't enable NKRO. If I toggle NKRO using MAGIC_KEY it does work. Is there any way to get this to enable on startup that I'm missing? I know recently this was an issue in TMK and Hasu was able to force NKRO while on USB but I can't seem to find the change he made in TMK and try to replicate here.

drashna commented 6 years ago

The commit in question is this: https://github.com/tmk/tmk_keyboard/commit/f2761c9565e76706853a4a0b148c8e93369e49e5

chadgrossman commented 6 years ago

Thanks for pointing that out, I got it working now by bringing over some of the changes from that commit.

drashna commented 6 years ago

Awesome. If you wanted to open a PR with the changes, that would be awesome!

chadgrossman commented 6 years ago

I'll try cleaning it up a little and reducing the changes to be only in that rn42 folder and do that. Thanks again!