qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.24k stars 39.3k forks source link

Update config.h template with new #defines #3947

Closed mechmerlin closed 4 years ago

mechmerlin commented 6 years ago

To save some more space in firmware, we can disable the handling for action_get_macros and fn_actions. They are depreciated so why not disable them?

Add the following to config.h template

#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

template files are located in:

  1. https://github.com/qmk/qmk_firmware/blob/master/quantum/template/avr/config.h
  2. https://github.com/qmk/qmk_firmware/blob/master/quantum/template/ps2avrgb/config.h
drashna commented 6 years ago

Better question is:

Since these features are depreciated, do we want to actually disable them by default, and allow them to be turned on for compatibility?

noroadsleft commented 6 years ago

@drashna

Since these features are depreciated

deprecated* :smile:

@mechmerlin I'm okay with the spirit of these changes, but a lot of the keymaps in the repo have been ported from TMK, so we would have to go through each keymap that uses fn_actions/action_get_macro and refactor its functionality into process_record_user.

mechmerlin commented 6 years ago

I think that's beyond the scope of this template change, but feel free to file another issue on it.

This and the changes you talked about sound like a good way for people new to QMK, to get their feet wet with coding.

jackhumbert commented 4 years ago

This was implemented in #7211.