qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.24k stars 39.31k forks source link

EEPROM support for Massdrop arm_atsam (CTRL & ALT) #4625

Closed helluvamatt closed 2 years ago

helluvamatt commented 5 years ago

Per the datasheet for ATSAMD51J18A the MCU has a SmartEEPROM function that allows up to 64K of EEPROM storage.

I am working on implementing this in tmk_core/common/arm_atsam/eeprom.c as that file is already set up to handle eeprom simulation in memory and it should be fairly simple to configure SmartEEPROM.

drashna commented 5 years ago

Well, check out the STM stuff too. I think that has some of the same limitations/issues that ATSAM has, so it would be a good place to look.

tprk77 commented 5 years ago

I've been watching this ticket, can I offer to help in some way?

drashna commented 5 years ago

There is a PR that adds persistent storage. So it maybe worth checking that out.

daltona commented 5 years ago

Well I'm sorry I missed this issue, but my implementation is actually implementing SmartEEPROM support, with a fallback to original functionality if SmartEEPROM is not enabled on the chip. Enabling SmartEEPROM can be done with a change that I've made to mdloader, referenced in #6068 So for sure I believe it exactly solves this issue.

zvecr commented 2 years ago

Fixed with 6068.