qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.25k stars 39.33k forks source link

compile fail when HHKB_RN42_ENABLE #4712

Closed foo1024 closed 5 years ago

foo1024 commented 5 years ago

Make finished with errors when HHKB_RN42_ENABLE

ver 0.6.204 is OK. ver 0.6.205 is NG

$ LANG=C make hhkb:default HHKB_RN42_ENABLE=yes
QMK Firmware 0.6.205
Making hhkb with keymap default

avr-gcc (GCC) 5.4.0
....
Compiling: keyboards/hhkb/rn42/rn42_task.c                                                         In file included from keyboards/hhkb/rn42/rn42_task.c:6: :
quantum/split_common/serial.h:18:45: error: 'SERIAL_SLAVE_BUFFER_LENGTH' undeclared here (not in a function)
 rn volatile uint8_t serial_slave_buffer[SERIAL_SLAV
                                         ^
quantum/split_common/serial.h:19:46: error: 'SERIAL_MASTER_BUFFER_LENGTH' undeclared here (not in a function)
 n volatile uint8_t serial_master_buffer[SERIAL_MAST
                                         ^
 [ERRORS]
 |
 |
 |
tmk_core/rules.mk:376: recipe for target '.build/obj_hhkb_default/rn42/rn42_task.o' failed
make[1]: *** [.build/obj_hhkb_default/rn42/rn42_task.o] Error 1
Make finished with errors
Makefile:529: recipe for target 'hhkb:default' failed
make: *** [hhkb:default] Error 1
drashna commented 5 years ago

it looks like the hhkb is using the split keyboard's serial files, becau$e it doesn't corre'tly have its own. so this would be the cause of the issue.