search

qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
17.97k stars 38.64k forks source link

Subprojects are compiled twice #504

Closed fredizzimo closed 8 years ago

fredizzimo commented 8 years ago

When running make-all-keyboards, the default subproject is compiled twice. Take a look at this for example.

You can see that for Clueboard it's doing

clueboard/clueboard clueboard/rev1 clueboard/rev2

And the same thing with Ergodox for example ergodox/ergodx ergodox/ez ergodx/infinity

It's not that bad, since quick compilation is used, so the second pass will be much faster, but still it probably shouldn't do that.

jackhumbert commented 8 years ago

Yeah, my Makefile skills were exhausted when trying to figure out how to exclude those. The output is also "keyboard/keyboard", which I was trying to avoid, but here we are :)

fredizzimo commented 8 years ago

Yes, I have had way too much fighting with make files during the past couple of weeks, so I know your feeling.

I might fix this at some point, but I don't promise anything at the moment.

ezuk commented 8 years ago

Closing this guy for now.