Is quantum/rgblight.c:eeconfig_update_rgblight() correct ?

qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

18.23k stars 39.3k forks source link

Is quantum/rgblight.c:eeconfig_update_rgblight() correct ? #5334

Closed mtei closed 5 years ago

mtei commented 5 years ago

The following 'rgblight_check_config()' does not seem to affect the contents writte to eeprom.

void eeconfig_update_rgblight(uint32_t val) {
  #if defined(__AVR__) || defined(STM32_EEPROM_ENABLE) || defined(PROTOCOL_ARM_ATSAM) || defined(EEPROM_SIZE)
    rgblight_check_config();
    eeprom_update_dword(EECONFIG_RGBLIGHT, val); // val is the previous rgblight_config.raw.
  #endif
}

drashna commented 5 years ago

You're absolutely correct. And that would need to be updated, then.

mtei commented 5 years ago

This issue was solved naturally by other improvements.