search

qmk / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
18.23k stars 39.26k forks source link

Windows, Ergodox, KC_SLEP #560

Closed hia3 closed 7 years ago

hia3 commented 8 years ago

Looks like after this commit KC_SLEP stopped working on Windows.

ezuk commented 8 years ago

Hi @hia3! Would you mind providing some more detail? Which version of Windows, maybe your keymap or repo? Or if you have positive proof that this is the issue, a PR with a possible fix?

hia3 commented 8 years ago

Sure. I'm building with Ubuntu (VirtualBox):

mkdir repro && cd repro/ git clone https://github.com/jackhumbert/qmk_firmware.git cd qmk_firmware/keyboards/ergodox_ez/ make keymap=ordinary

And test on Windows 10: press and hold "Media Tab" button (3rd led will turn on). Then press Sleep button - nothing will happen.

Changing all 0x0081 back to 0x0001 in tmk_core/protocol/lufa/descriptor.c helps.

Btw, regardless of this commit I've never been able to wake up the PC with ErgoDox EZ (even though waking up with another keyboard works just fine).

ezuk commented 8 years ago

@jackhumbert what do you think? Seems like a good isolation of a bug imho. Also, can people wake up Windows machines with the Planck? Trying to understand if this is keyboard specific.

jackhumbert commented 7 years ago

It looks like #963 addressed this - @hia3, if this isn't the case, please reopen this!