search

qmk / qmk_flasher

flashing utility for the Atmel AVR USB family
MIT License
63 stars 24 forks source link

Simple/Expert UI changer #36

Closed skullydazed closed 7 years ago

skullydazed commented 7 years ago

Opened a new PR because #24 got too complicated after the restructuring.

skullydazed commented 7 years ago

One problem I'm still trying to figure out is why the gear menu opens the menu 200 pixel below the window, rather than inside the window.

NoahAndrews commented 7 years ago

Right now, the menu opens at a specific position relative to (I believe) the top left corner. It would probably be better to define its position from one of the bottom corners, to avoid issues like this when the window size changes.

skullydazed commented 7 years ago

I've rebased this branch off #43. We'll need to merge #43 before this gets merged.

skullydazed commented 7 years ago

I'm pretty happy with how this works now. I need to test on windows and in packaged versions, but if it looks good there I'm ready to merge this.