qmk / qmk_toolbox

A Toolbox companion for QMK Firmware
https://qmk.fm/toolbox
MIT License
2.6k stars 507 forks source link

Arm binaries for dfu-programmer etc. #378

Open Muirium opened 2 years ago

Muirium commented 2 years ago

The command line utilities QMK Toolbox uses internally are currently all Intel builds on Mac. Run file * on the Resources directory inside the app to check them out. This is not a problem yet, as they run under Rosetta. But fully native / Universal builds are a good idea going forward as Rosetta is a transitional technology which won't stay around forever. I substituted dfu-programmer for the Apple Silicon native version in Homebrew. Works perfectly. But now I've updated QMK Toolbox to the current version, I see they are Intel only again.

Feature Request Type

Description

fauxpark commented 2 years ago

The Toolbox itself is currently built as a universal binary, but the deployment target is set to 10.15 (following Homebrew minimum system requirements because the flasher binaries are taken from the bottles). Even then, I don't think Brew builds universal binaries - the bottles are separate for Intel and Apple Silicon.

Muirium commented 2 years ago

True!

dfu-programmer: Mach-O 64-bit executable arm64 dfu-util: Mach-O 64-bit executable x86_64

I’m not technical enough to know how hard it is to “stitch” both architectures into a single Universal binary. Hadn’t even realised my build was exclusively Arm64.

Obviously enough, Universal is the way to go. Plenty of Intel Macs still out there. For now…

joxelstudios commented 6 months ago

Commenting here instead of creating a new issue. Just tested the latest release (0.3.0) and can confirm the intel DFU binaries run and flash fine under Rosetta. I flashed an update for my Nuphy Air60 V2 on an M1 Max Macbook Pro.

jajajaime commented 1 month ago

Adding a comment as well that using the latest release 0.3.3 did not give me any issues on a MacBook Pro M1 Pro for a Nuphy Air75 V2.