search

qmlcode / qml

QML: Quantum Machine Learning
MIT License
197 stars 84 forks source link

Remove Dataprovider from data/ remove ASE dependency #106

Closed andersx closed 5 years ago

andersx commented 5 years ago

As said in title. These are superseeded by the QMLearn interface.

This will also remove the dependency on ASE, as far as I can see.

Any downsides to this @larsbratholm ?

larsbratholm commented 5 years ago

The ASE interface might be nice to have in the future for other filetypes than XYZ. But they should inherit from the Data class. Until someone actually adds something that depends on ASE, we should indeed remove the dependency.

andersx commented 5 years ago

I'll make a PR to remove the outdated dataprovider and (for now) remove ase then!

andersx commented 5 years ago

Closing this now that PR #108 is accepted!