search

qmlcode / qml

QML: Quantum Machine Learning
MIT License
197 stars 84 forks source link

FCHL python/fortran interface bug #86

Closed larsbratholm closed 5 years ago

larsbratholm commented 6 years ago

The same fortran function is called two different places in the code, using different parameters.

https://github.com/qmlcode/qml/blob/develop/qml/fchl/fchl_scalar_kernels.py#L132

https://github.com/qmlcode/qml/blob/develop/qml/fchl/fchl_kernels.py#L148

One has a verbose flag and one does not, so one of them must be wrong?

larsbratholm commented 6 years ago

The fchl_kernels file does not seem to be used anywhere, so I assume that it's legacy code and can be removed?

andersx commented 6 years ago

Yeah, that one should have been removed!