fixed evaluation of properties named property

qmlweb / qmlweb-parser

A QML parser in JavaScript

Other

27 stars 11 forks source link

fixed evaluation of properties named property #23

Closed machinekoder closed 7 years ago

machinekoder commented 7 years ago

Fixes https://github.com/qmlweb/qmlweb/issues/346

ChALkeR commented 7 years ago

LGTM with a nit (unnecessary if nesting).

Thanks!

ChALkeR commented 7 years ago

Thanks, landed in dfbcf70!

There was some more dead code, so I removed all those in a separate commit (eba88a9), and then rebased the actual change from this PR manually.

machinekoder commented 7 years ago

Awesome! When will you publish the next release?

ChALkeR commented 7 years ago

@machinekoder qmlweb-parser — just published 0.3.1. qmlweb — not sure yet, I was hoping to finish some more structural changes before 0.2.0, but I might postpone those and release 0.2.0 pretty soon instead.