The current version of the BPF Instruction Set Specification specifies that "Shift operations use a mask of 0x3F (63) for 64-bit operations and 0x1F (31) for 32-bit operations".
The current implementation is not compliant, and Rust complains if we overflow the number of bits we have when trying to shift. Let's fix it, and let's complete the test suite regarding left and right shift operations.
Note: The JITs are not updated at this stage. The standard does no. mention any difference between JIT and interpreter, but the kernel clearly considers the masking for the interpreter only. JIT-compilers are supposed to handle the overflow case in an implementation-defined (architecture-dependant) fashion. Kernel also use masking for shifts with registers only (not immediates) and handles overflows with immediates in the verifier by rejecting the programs.
The current version of the BPF Instruction Set Specification specifies that "Shift operations use a mask of 0x3F (63) for 64-bit operations and 0x1F (31) for 32-bit operations".
The current implementation is not compliant, and Rust complains if we overflow the number of bits we have when trying to shift. Let's fix it, and let's complete the test suite regarding left and right shift operations.
Note: The JITs are not updated at this stage. The standard does no. mention any difference between JIT and interpreter, but the kernel clearly considers the masking for the interpreter only. JIT-compilers are supposed to handle the overflow case in an implementation-defined (architecture-dependant) fashion. Kernel also use masking for shifts with registers only (not immediates) and handles overflows with immediates in the verifier by rejecting the programs.
Fixes: #99