search

qmsk / e2

E2 Client, Tally output
Mozilla Public License 2.0
26 stars 7 forks source link

GPIO red/green status should also work without any tally pins #17

Closed SpComb closed 7 years ago

SpComb commented 7 years ago

Currently the GPIO driver defaults the statusGreen to low, and sets it high if it find any existing tally pin state: https://github.com/qmsk/e2/blob/v0.4.1/gpio/gpio.go#L134

However, this means that the green status pin remains low if the GPIO driver is only used for the red/green status pins, without any tally pins.

The GPIO driver should use the tally:State.Sources[...].Connected states to determine the status instead.

Depends on #16 to correctly set that status flag.

SpComb commented 7 years ago

Fixed by #18