search

qmuntal / gltf

Go library for encoding glTF 2.0 files
https://www.khronos.org/gltf/
BSD 2-Clause "Simplified" License
242 stars 32 forks source link

Fix module line #2

Closed matt0xFF closed 5 years ago

matt0xFF commented 5 years ago

Thanks for open sourcing this! I tried using it as a dependency (using modules) but got the following error:

go get github.com/qmuntal/gltf
go: finding github.com/qmuntal/gltf v0.7.0
go: github.com/qmuntal/gltf@v0.7.0: parsing go.mod: unexpected module path "gltf"
go: error loading module requirements

I'm not an expert on modules, but after looking in to it it looks like the module path is specified incorrectly (the examples at github.com/golang/go/wiki/Modules use the whole path including github). I also tested the fix by updating the path on my fork (to my fork URL) and it fixed the issue.

In order for go get to see it it will need a new release with a version bump too.

qmuntal commented 5 years ago

Many thanks! The other day I was also experimenting this issue but I though it had something to do with my local modules config. I've checked other popular modules and I confirmed that the full uri is necessary in the module file, so I'll release a new version with this fix