search

qnighy / yasna.rs

ASN.1 library for Rust
Apache License 2.0
42 stars 31 forks source link

Update bit-vec to 0.6 #38

Closed est31 closed 5 years ago

qnighy commented 5 years ago

MSRV breaking?

est31 commented 5 years ago

@qnighy yeah there are two MSRV breakages, one earlier on in the update from 0.5.0 to 0.5.1 to rustc 1.17.0, and one later on to most likely rustc 1.30.0 in the 0.6.0 upgrade. I would be okay with increasing the MRSV of yasna to 1.17.0 but 1.30.0 right away? Rather not. Actually that second breakage is in their serde code. I have filed an issue and a PR so that serde can be disabled because it's a big dependency included basically for no reason. We don't need it and it's causing us issues with the MSRV. If you apply my PR to bit-vec, it compiles fine on 1.17.0.

As there is no feedback for my PR maybe we could find alternatives like removing the bit-vec dependency entirely. it's not that we need bit-vec really much. We can just operate with self-made types like BitVec(&[u8], usize)'s. Does removing bit-vec from yasna if there's been no response for my PR for two weeks sound alright?